Changes between Version 17 and Version 18 of Commentary/Compiler/NewCodeGenStupidity


Ignore:
Timestamp:
Apr 14, 2011 10:23:12 AM (4 years ago)
Author:
ezyang
Comment:

Fixed.

Legend:

Unmodified
Added
Removed
Modified
  • Commentary/Compiler/NewCodeGenStupidity

    v17 v18  
    9595~~We need to not spill across certain foreign calls, but for which calls this is OK for is unclear.~~ Variables stay live across all unsafe foreign calls (foreign calls in the middle), except for the obvious cases (the return registers), so no spilling should happen at all. The liveness analysis is too conservative. 
    9696 
    97 This is not fixed in the April 14 version of the patch... we still need to fix the liveness analysis? I thought I fixed that... 
     97This is not fixed in the April 14 version of the patch... we still need to fix the liveness analysis? I thought I fixed that... that's because the transform did extra spilling for CmmUnsafeForeignCalls. Removed that code, and now it's fixed. Testing changes. 
    9898 
    9999== Up and Down ==