Changes between Version 12 and Version 13 of Commentary/CodingStyle


Ignore:
Timestamp:
Sep 3, 2007 11:32:41 PM (7 years ago)
Author:
igloo
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • Commentary/CodingStyle

    v12 v13  
    134134If the module can be compiled multiple ways (eg. GHCI vs. non-GHCI), make sure the imports are properly `#ifdefed` too, so as to avoid spurious unused import warnings.  
    135135 
     136== Warnings == 
    136137 
     138We are aiming to make the GHC code warning-free for all warnings turned on by 
     139{{{ 
     140-Wall -fno-warn-name-shadowing 
     141}}} 
     142and as such the build sets these flags for the stage 2 compiler, and the validate script, which is used to test the build before commiting, additionally sets the `-Werror` flag. As the `-Werror` flag is not set during normal builds, during development warnings will be printed but won't halt the build. 
    137143 
     144Currently we are some way from our goal, so many modules have a 
     145{{{ 
     146{-# OPTIONS -w #-} 
     147}}} 
     148pragma; you are encouraged to remove this pragma and fix any warnings when working on a module.