Opened 3 years ago

Closed 2 years ago

#9950 closed bug (fixed)

Documentation for InterruptibleFFI contains broken example

Reported by: hpd Owned by: erdeszt
Priority: normal Milestone: 7.10.2
Component: Documentation Version: 7.8.4
Keywords: newcomer Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s): Phab:D902
Wiki Page:

Description

In Section "8.1.4. Interruptible foreign calls" the example

foreign import ccall interruptible
   "sleep" :: CUint -> IO CUint

misses the haskell function name.

Change History (9)

comment:1 Changed 3 years ago by thomie

Keywords: newcomer added

comment:2 Changed 3 years ago by erdeszt

Owner: set to erdeszt

comment:3 Changed 3 years ago by erdeszt

Differential Rev(s): Phab:D902
Status: newpatch

comment:4 Changed 3 years ago by erdeszt

I've added the name sleepBlock that's how it's refered in the codebase (although with slightly different signature, not sure if it matters). I also see that the version says 7.8.4 but I've made my fix on the latest master. Is it my responsibility to add it to the older branches or is it done automatically? (Sorry, first contribution and couldn't find relevant info in wiki)

comment:5 Changed 3 years ago by Thomas Miedema <thomasmiedema@…>

In 326989ed06e6ad52d1cc2307be19d21b66b95813/ghc:

Add missing name for FFI import (fixes #9950)

Signed-off-by: erdeszt <erdeszt@gmail.com>

Reviewed By: bgamari, thomie

Differential Revision: https://phabricator.haskell.org/D902

comment:6 Changed 3 years ago by thomie

Milestone: 7.12.1
Resolution: fixed
Status: patchclosed

In general we only work on master. Only important fixes are backported to the 7.10 (or latest release) branch by the release manager. You can read more about that here: https://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/Releases

The meaning of the version field is explained here : https://ghc.haskell.org/trac/ghc/wiki/ReportABug#Whattoputinabugreport

Thanks for the patch.

comment:7 Changed 3 years ago by erdeszt

Thank you for the links, will read through through them!

comment:8 Changed 2 years ago by thoughtpolice

Milestone: 7.12.17.10.2
Status: closedmerge

We can totally merge this one to STABLE, though.

comment:9 Changed 2 years ago by thoughtpolice

Status: mergeclosed

Merged to ghc-7.10.

Note: See TracTickets for help on using tickets.