Opened 3 years ago

Closed 2 years ago

Last modified 23 months ago

#9912 closed bug (fixed)

Allow access to full logs in Harbormaster builds

Reported by: goldfire Owned by: thoughtpolice
Priority: normal Milestone: 8.0.1
Component: Trac & Git Version:
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

Harbormaster helpfully tries building every commit and every differential revision. However, when it fails, we only get the tail of the output, with no way to get more information.

A case in point is this build, where a performance test case failed with [stat too good]. In this particular case, the commit is intended to be an optimization, so this failure is not terribly unexpected. I wanted to update all.T with the new figure, but I couldn't get the figure that Harbormaster's configuration had. Instead, I had to run the test on my machine (a Mac), get a different number, and hope that Harbormaster's configuration fell within 5% of mine. It did, in this case, but might not next time.

Change History (7)

comment:1 Changed 3 years ago by hvr

Owner: changed from hvr to thoughtpolice
Version: 7.8.3

comment:2 Changed 3 years ago by goldfire

I thought "Trac & Git" was the best value for the Component field for this ticket, and that component sets the owner to hvr. Perhaps there should be a new Phab component?

In any case, I wasn't intending to say that hvr is responsible here!

comment:3 Changed 2 years ago by thomie

Resolution: fixed
Status: newclosed

Phabricator now show 1000 lines of log on failed builds. Ping thoughtpolice or open a ticket here if that's still not good enough: https://github.com/haskell-infra/phab-ghc-builder.

comment:4 Changed 2 years ago by goldfire

Why can't we just have no limit? Or an option to download the original log? Though I don't have a concrete example, I think 1000 is way too small, given that there are almost 5000 test cases. If an early one fails, we won't be able to see the failure output. (This is not to suggest that 5000 would be a good limit, a priori. Does each test case use only one line of output?)

comment:5 Changed 2 years ago by thomie

Ask thoughtpolice. Something about Phabricator putting the logfile in a database record.

But only tests that fail produce output (Phabricator calls make test VERBOSE=1), so unless you have 5000 failing test cases, you should be ok.

comment:6 Changed 2 years ago by goldfire

Ah. That's a bit better than. 1000 might indeed be enough. Thanks!

comment:7 Changed 23 months ago by thomie

Milestone: 8.0.1
Note: See TracTickets for help on using tickets.