Opened 3 years ago

Closed 2 years ago

Last modified 21 months ago

#9751 closed task (fixed)

add runMeta Hook or TcM variant of hscCompileCoreExprHook

Reported by: luite Owned by: luite
Priority: normal Milestone: 8.0.1
Component: GHC API Version: 7.8.3
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s): Phab:D501
Wiki Page:

Description

GHCJS has to jump through hoops to make annotations work and to get the necessary information for linking a TH splice. The main reason is that hscCompileCoreExprHook does not expose the TcM environment.

Easiest fix would be to add

hscCompileCoreExprTcMHook :: HscEnv -> SrcSpan -> CoreExpr -> TcM HValue

to Hooks, but it'd be better to hook runMeta instead. Unfortunately runMeta is polymorphic, so it could be more tricky. I'm going to see if I can hook runMeta in a reasonable way, and if I run out of time for 7.10.1, send a patch with hscCompileCoreExprTcMHook instead.

Change History (4)

comment:1 Changed 3 years ago by luite

Differential Rev(s): Phab:D501

comment:2 Changed 2 years ago by thoughtpolice

Milestone: 7.10.17.12.1

Moving to 7.12.1 milestone; if you feel this is an error and should be addressed sooner, please move it back to the 7.10.1 milestone.

comment:3 Changed 2 years ago by luite

Resolution: fixed
Status: newclosed

comment:4 Changed 21 months ago by thoughtpolice

Milestone: 7.12.18.0.1

Milestone renamed

Note: See TracTickets for help on using tickets.