Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#9317 closed bug (fixed)

Add PolyKinds extension to Data.Monoid

Reported by: bernalex Owned by:
Priority: low Milestone: 7.10.1
Component: libraries/base Version: 7.8.2
Keywords: Cc: hvr, ekmett
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Revisions: Phab:D70

Attachments (1)

0001-Add-PolyKinds-extension-to-Data.Monoid.patch (1.9 KB) - added by bernalex 14 months ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 14 months ago by bernalex

  • Status changed from new to patch

comment:2 Changed 14 months ago by ekmett

This was very much an accidental regression, not something consciously done. Makes sense to fix it.

comment:3 Changed 14 months ago by bernalex

  • Differential Revisions set to Phab:D70

comment:4 Changed 14 months ago by Austin Seipp <austin@…>

In 18b2c46773eccb974bdd042a2f400edd23e193d7/ghc:

Add PolyKinds extension to Data.Monoid

Summary:
Carl Howells pointed out[0] that the `Monoid` instance for
`Data.Proxy.Proxy` is only defined for types with kind *.

This is a very mild change. Furthermore, Edward Kmett revealed[1] that
it was supposed to be there all along -- the extension simply got lost
in commit 1d1ff77aaa09efaddc8cfe0dcf92d6763297cf11, as pointed out by
Adam Vogt[2]. This used to be correct in GHC 7.6, so this commit fixes a
regression.

This addresses #9317.

[0] <http://www.haskell.org/pipermail/libraries/2014-July/023261.html>.
[1] <http://www.haskell.org/pipermail/libraries/2014-July/023267.html>.
[2] <http://www.haskell.org/pipermail/libraries/2014-July/023265.html>.

Signed-off-by: Alexander Berntsen <[email protected]>

Test Plan: See [0]

Reviewers: austin, hvr, ekmett

Reviewed By: austin, hvr, ekmett

Subscribers: phaskell, simonmar, relrod, carter

Differential Revision: https://phabricator.haskell.org/D70

comment:5 Changed 14 months ago by thoughtpolice

  • Resolution set to fixed
  • Status changed from patch to closed

Merged, thanks!

comment:6 Changed 14 months ago by thoughtpolice

  • Milestone set to 7.10.1
Note: See TracTickets for help on using tickets.