Opened 3 years ago

Closed 2 years ago

#9126 closed bug (fixed)

-ddump-to-file in TcRnMonad.lhs

Reported by: GregWeber Owned by: GregWeber
Priority: normal Milestone: 7.10.1
Component: Compiler Version: 7.8.2
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: #8624 Differential Rev(s): Phab:D460
Wiki Page:

Description (last modified by GregWeber)

As part of #8624, the first thing we realized is -ddump-to-file wasn't being respected. The patch is against HEAD.

I tested this with -ddump-tc and -ddump-splices.

Attachments (1)

0001-make-TcRnMonad.lhs-respect-ddump-to-file.patch (3.7 KB) - added by GregWeber 3 years ago.
-ddump-to-file patch

Download all attachments as: .zip

Change History (12)

Changed 3 years ago by GregWeber

-ddump-to-file patch

comment:1 Changed 3 years ago by GregWeber

Status: newpatch

comment:2 Changed 3 years ago by GregWeber

It looks like there are a few test case failures, I will try to clean them up.

comment:3 Changed 3 years ago by GregWeber

Owner: set to GregWeber

comment:4 Changed 3 years ago by GregWeber

Description: modified (diff)

comment:5 Changed 3 years ago by thoughtpolice

Status: patchinfoneeded

Do let me know if you have any updates on this and put it back to patch status, please.

comment:6 Changed 2 years ago by GregWeber

Status: infoneededpatch

comment:8 Changed 2 years ago by goldfire

Differential Rev(s): Phab:D460

comment:9 Changed 2 years ago by simonpj

Milestone: 7.10.1

Let's do this for 7.10

comment:10 Changed 2 years ago by Austin Seipp <austin@…>

In 33c029faef3b5e486def8f3a7c888dfa9f3d8cca/ghc:

make TcRnMonad.lhs respect -ddump-to-file

Summary: allows things such as: -ddump-to-file -ddump-splices

Test Plan:
compile with flags -ddump-to-file -ddump-splices
verify that it does output an extra file

Try out other flags.
I noticed that with -ddump-tc there is some output going to file and some to stdout.

Reviewers: hvr, austin

Reviewed By: austin

Subscribers: simonpj, thomie, carter

Differential Revision: https://phabricator.haskell.org/D460

GHC Trac Issues: #9126

comment:11 Changed 2 years ago by thomie

Resolution: fixed
Status: patchclosed
Note: See TracTickets for help on using tickets.