Opened 3 years ago

Closed 3 years ago

#9068 closed bug (fixed)

Don't uninstall signal handlers if none were installed

Reported by: tomgr Owned by: simonmar
Priority: normal Milestone: 7.8.3
Component: Runtime System Version: 7.8.2
Keywords: Cc: simonmar
Operating System: Windows Architecture: Unknown/Multiple
Type of failure: Incorrect result at runtime Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

GHC 7.8.2 calls resetSignalHandlers even when --install-signal-handlers=no is specified. On windows this results in the call to SetConsoleCtrlHandler failing.

The attached patch only calls resetSignalHandlers when there are signal handlers to remove (it mirrors the logic used when installing the handlers).

Attachments (1)

reset-sig-handlers.patch (539 bytes) - added by tomgr 3 years ago.

Download all attachments as: .zip

Change History (4)

Changed 3 years ago by tomgr

Attachment: reset-sig-handlers.patch added

comment:1 Changed 3 years ago by Simon Marlow <marlowsd@…>

In bc7d49a658a516679cc264502e72560c1d2c2314/ghc:

Only uninstall signal handlers if they were actually installed (#9068)

Submitted by: tomgr

comment:2 Changed 3 years ago by simonmar

Milestone: 7.8.3
Status: newmerge

comment:3 Changed 3 years ago by thoughtpolice

Resolution: fixed
Status: mergeclosed

Merged, thanks!

Note: See TracTickets for help on using tickets.