#9029 closed bug (fixed)

[CID43142] Check return value of sigaction

Reported by: nicolast Owned by: thoughtpolice
Priority: normal Milestone: 7.8.3
Component: Runtime System Version: 7.8.2
Keywords: coverity Cc: simonmar
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Revisions:

Description

Coverity pointed at a location where the return value of sigaction isn't checked, unlike other occurrences of the function call.

This patch adds the call, in line with other code.

Attachments (1)

0002-Check-return-value-of-sigaction.patch (895 bytes) - added by nicolast 12 months ago.

Download all attachments as: .zip

Change History (4)

Changed 12 months ago by nicolast

comment:1 Changed 12 months ago by simonmar

  • Milestone set to 7.8.3
  • Owner changed from simonmar to thoughtpolice

Looks good to me. Austin, could you push please?

comment:2 Changed 12 months ago by nicolast

Austin: in case you find it more convenient to cherry-pick the patch from a git tree instead of applying a Trac attachment, the patches I submitted based on the Coverity results can be found at git://github.com/NicolasT/ghc.git in the 'coverity' branch.

comment:3 Changed 12 months ago by thoughtpolice

  • Resolution set to fixed
  • Status changed from new to closed

Merged in HEAD and 7.8 this morning, thanks!

Note: See TracTickets for help on using tickets.