#8771 closed bug (fixed)

ASSERT unexpanded in compiler/coreSyn/CoreSubst.lhs

Reported by: jkarni Owned by:
Priority: normal Milestone:
Component: Compiler Version: 7.9
Keywords: Cc:
Operating System: MacOS X Architecture: Unknown/Multiple
Type of failure: Building GHC failed Test Case:
Blocked By: Blocking:
Related Tickets: Differential Revisions:

Description

An ASSERT macro in compiler/coreSyn/CoreSubst.lhs isn't being expanded because of a space before the parens. The error:

 make -j3
...
"/usr/local/bin/ghc" -hisuf hi -osuf  o -hcsuf hc -static  -H32m -O -Werror -Wall -H64m -O0  -package-db libraries/bootstrapping.conf  -package-name ghc-7.9 -hide-all-packages -i -icompiler/basicTypes -icompiler/cmm -icompiler/codeGen -icompiler/coreSyn -icompiler/deSugar -icompiler/ghci -icompiler/hsSyn -icompiler/iface -icompiler/llvmGen -icompiler/main -icompiler/nativeGen -icompiler/parser -icompiler/prelude -icompiler/profiling -icompiler/rename -icompiler/simplCore -icompiler/simplStg -icompiler/specialise -icompiler/stgSyn -icompiler/stranal -icompiler/typecheck -icompiler/types -icompiler/utils -icompiler/vectorise -icompiler/stage1/build -icompiler/stage1/build/autogen -Icompiler/stage1/build -Icompiler/stage1/build/autogen -Icompiler/. -Icompiler/parser -Icompiler/utils -Icompiler/stage1    -optP-include -optPcompiler/stage1/build/autogen/cabal_macros.h -package Cabal-1.18.1.3 -package array-0.4.0.1 -package base-4.6.0.1 -package bin-package-db-0.0.0.0 -package bytestring-0.10.0.2 -package containers-0.5.0.0 -package directory-1.2.0.1 -package filepath-1.3.0.1 -package hoopl-3.10.0.0 -package hpc-0.6.0.1 -package process-1.1.0.2 -package time-1.4.0.1 -package transformers-0.3.0.0 -package unix-2.6.0.1 -Wall -fno-warn-name-shadowing -XHaskell98 -XCPP -XMagicHash -XUnboxedTuples -XPatternGuards -XForeignFunctionInterface -XEmptyDataDecls -XTypeSynonymInstances -XMultiParamTypeClasses -XFlexibleInstances -XRankNTypes -XScopedTypeVariables -XDeriveDataTypeable -XBangPatterns -XNondecreasingIndentation -DSTAGE=1  -fwarn-tabs -O  -no-user-package-db -rtsopts      -odir compiler/stage1/build -hidir compiler/stage1/build -stubdir compiler/stage1/build   -c compiler/coreSyn/CoreSubst.lhs -o compiler/stage1/build/CoreSubst.o

compiler/coreSyn/CoreSubst.lhs:1360:7:
    Not in scope: data constructor `ASSERT'
make[1]: *** [compiler/stage1/build/CoreSubst.o] Error 1
make: *** [all] Error 2

/usr/local/bin/ghc is version 7.6.3. I'm building HEAD, which is at commit 5d04603b33d285565774, though a27b2985511800fa3b740fef82 (HEAD~2) introduced the code in question.

This is, I'm pretty sure, literally a one character (and a whitespace, at that) fix. Attached is the patch.

Attachments (1)

0001-Remove-space-after-ASSERT.patch (976 bytes) - added by jkarni 13 months ago.
Remove space after ASSERT

Download all attachments as: .zip

Change History (3)

Changed 13 months ago by jkarni

Remove space after ASSERT

comment:1 Changed 13 months ago by jkarni

  • Status changed from new to patch

comment:2 Changed 13 months ago by ezyang

  • Resolution set to fixed
  • Status changed from patch to closed

Thanks, applied.

commit 3d9644c2fc705ec80a8a63b0b698d74cd2d49212
Author: Julian K. Arni <[email protected]>
Date:   Wed Feb 12 04:11:31 2014 -0200

    Remove space after ASSERT.
    
      Which on OS X leaves macro unexpanded.
Note: See TracTickets for help on using tickets.