Opened 4 years ago

Closed 2 years ago

Last modified 2 years ago

#8723 closed task (fixed)

sdist should not have to build everything

Reported by: nomeata Owned by:
Priority: low Milestone: 8.0.1
Component: Build System Version: 7.6.3
Keywords: Cc: hvr
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s): Phab:D917
Wiki Page:

Description

It would be nice if instead of

$ perl boot
$ ./configure
$ make
$ make sdist

it would suffice to run

$ perl boot
$ ./configure
$ make sdist

and if that would not build more than necessary to generate the tarballs.

It would save time on the GHC-HEAD-Debian-Package-autobuilder that I am currently working on.

I might look into this bug eventually, but if someone else feels like doing it: Even better. (Difficulty estimated conservatively; might well be less than an hour, besides maybe waiting for test runs to finish :-))

Remember to update MakingReleases and Building/StandardTargets if this is implemented.

Change History (6)

comment:1 Changed 3 years ago by hvr

Cc: hvr added

comment:2 Changed 2 years ago by thomie

Differential Rev(s): Phab:D917
Milestone: 7.12.1
Status: newpatch

Took me quite a bit longer then one hour, but I have a patch up in Phab:D917.

comment:3 Changed 2 years ago by thomie

How about adding happy and alex to the build requirements for building from source tarballs?

Then generating a source tarball becomes easier.

As suggested by simon in ticket:1693#comment:25.

Last edited 2 years ago by thomie (previous) (diff)

comment:4 Changed 2 years ago by Thomas Miedema <thomasmiedema@…>

In 092082e7583c8170ae41ef8d01a554db34f91bb3/ghc:

Build: ./boot && ./configure && make sdist (#8723)

Make it possible to run `make sdist` right after configure, without completing
a complete build first.

Test Plan:
I compared the contents of the created `.tar.bz2` files in the `sdistprep`
directory, after running `make sdist` both before and after completing a full
build, using `diff -r`. There weren't any differences (after applying the
patches from D914).

Note that the `.tar.bz2` files were not exactly the same size, but they aren't
either when tarring and bzipping the same directory twice. It seems tarring
and bzipping is not deterministic (on my system).

Differential Revision: https://phabricator.haskell.org/D917

comment:5 Changed 2 years ago by thomie

Resolution: fixed
Status: patchclosed

comment:6 Changed 2 years ago by thoughtpolice

Milestone: 7.12.18.0.1

Milestone renamed

Note: See TracTickets for help on using tickets.