Opened 3 months ago

Closed 2 months ago

#8722 closed bug (fixed)

powerpc64: error Cannot find a way to declare the thread-local gc variable

Reported by: trommler Owned by: thoughtpolice
Priority: normal Milestone: 7.8.1
Component: Compiler Version: 7.8.1-rc1
Keywords: Cc:
Operating System: Linux Architecture: powerpc64
Type of failure: Building GHC failed Difficulty: Easy (less than 1 hour)
Test Case: Blocked By:
Blocking: Related Tickets:

Description

Building 7.8.RC1 on powerpc64 fails with:

[ 2883s] In file included from rts/sm/GCUtils.h:19:0,
[ 2883s]                  from rts/sm/Scav.c:20:
[ 2883s] rts/sm/GCTDecl.h:139:2: error: #error Cannot find a way to declare the thread-local gc variable!
[ 2883s]  #error Cannot find a way to declare the thread-local gc variable!
[ 2883s]   ^
[ 2883s] rts/ghc.mk:512: recipe for target 'rts/dist/build/.depend-v-l-debug-thr-thr_debug-thr_l.c_asm' failed
[ 2883s] make[1]: *** [rts/dist/build/.depend-v-l-debug-thr-thr_debug-thr_l.c_asm] Error 1

The build is unregisterized (default) and does not use dynamic linking (DYNAMIC_GHC_PROGRAMS=NO and DYNAMIC-BY_DEFAULT=NO).

It might be related to #8301.

Attachments (1)

0001-fix-__thread-detection.patch (875 bytes) - added by trommler 3 months ago.

Download all attachments as: .zip

Change History (8)

Changed 3 months ago by trommler

comment:1 Changed 3 months ago by trommler

  • Difficulty changed from Unknown to Easy (less than 1 hour)
  • Owner set to trommler

The above patch might fix the issue. I will wait for my builds on x86, x86_64 and powerpc64 and then set the ticket to patch.

comment:2 Changed 3 months ago by trommler

  • Status changed from new to patch

x86 and x86_64 builds are all fine. On powerpc64 I now get #8301 again.

Please review the patch and consider merging it into 7.8.

PS: I wonder if https://ghc.haskell.org/trac/ghc/changeset/48326cfb1ef4b455f81fbbece7a17dab17f7c932/ghc
is still needed?

comment:3 Changed 3 months ago by thoughtpolice

  • Milestone set to 7.8.1
  • Owner changed from trommler to thoughtpolice

Good catch, total failure on my part. I'll fix and merge to 7.8 as I now have a fancy new PPC64 machine to test with!

comment:4 Changed 3 months ago by Austin Seipp <austin@…>

In 298a25bdfd02bb591fde2dd0590bd7af81a91b94/ghc:

Fix __thread detection (#8722)

Signed-off-by: Austin Seipp <austin@well-typed.com>

comment:5 Changed 3 months ago by Austin Seipp <austin@…>

In b4eb630c7480bc56c673a463f274aec18e237e8c/ghc:

Remove ios_HOST check for GCTDecl.h

Following 298a25bdf and #8722 as Peter mentioned, this probably isn't
needed anymore.

Signed-off-by: Austin Seipp <austin@well-typed.com>

comment:6 Changed 3 months ago by thoughtpolice

  • Status changed from patch to merge

comment:7 Changed 2 months ago by thoughtpolice

  • Resolution set to fixed
  • Status changed from merge to closed

Merged.

Note: See TracTickets for help on using tickets.