#8434 closed task (fixed)

dynflag dependency addition in TcRnDriver is not needed anymore

Reported by: errge Owned by:
Priority: normal Milestone: 7.8.1
Component: Compiler Version: 7.6.3
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: Other Test Case:
Blocked By: Blocking:
Related Tickets: Differential Revisions:

Description (last modified by simonpj)

The removed parts of the tcRnImports function in the attached patch says that there is a check in LoadIface.loadInterface and this is why it's needed to add the plugin dependencies to the EPS.

But actually compiler/iface/LoadIface.lhs#L227 says that the check is no longer there.

Attachments (1)

ghc-simplyfy.patch (1.3 KB) - added by errge 19 months ago.

Download all attachments as: .zip

Change History (7)

Changed 19 months ago by errge

comment:1 Changed 19 months ago by errge

  • Status changed from new to patch

comment:2 Changed 19 months ago by simonpj

  • Description modified (diff)

Yes ok I agree. Austin, please apply. (errge, you did validate didn't you)

comment:3 Changed 19 months ago by errge

I did a: make -C testsuite fast THREADS=6 VERBOSE=2 SKIP_PERF_TESTS=YES

comment:4 Changed 19 months ago by thoughtpolice

LGTM. On my queue...

comment:5 Changed 19 months ago by Austin Seipp <austin@…>

In eafae362ddc838245b3a50e1fb039cb6f211f801/ghc:

Remove outdated comment (#8434)

Authored-by: Gergely Risko <[email protected]>
Signed-off-by: Austin Seipp <[email protected]>

comment:6 Changed 19 months ago by thoughtpolice

  • Resolution set to fixed
  • Status changed from patch to closed

Merged, thanks!

Note: See TracTickets for help on using tickets.