Opened 6 months ago

Closed 6 months ago

#8418 closed bug (fixed)

[patch] comments outdated

Reported by: errge Owned by:
Priority: normal Milestone: 7.8.1
Component: Compiler Version: 7.6.3
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Difficulty: Easy (less than 1 hour)
Test Case: Blocked By:
Blocking: Related Tickets:

Description (last modified by hvr)

During working on GHC, I found these outdated comments and function names.

The ForPlugins renaming in compiler/main/DynamicLoading.hs is motivated by the fact that change [57d67983] crippled the function in a way that now it can only be used while handling Plugins. Therefore the name should warn the programmer to this fact.

The hptInstances comment has also been outdated, when someone needed to add the ModuleName -> Bool predicate to use this same function for handling ghc and ghci with shared code.

The attached patch is trivial renames/comments.

Attachments (1)

ghc-comments.patch (4.7 KB) - added by errge 6 months ago.

Download all attachments as: .zip

Change History (5)

Changed 6 months ago by errge

comment:1 Changed 6 months ago by errge

  • Status changed from new to patch

comment:2 Changed 6 months ago by hvr

  • Description modified (diff)

comment:3 Changed 6 months ago by Austin Seipp <austin@…>

In 7fad107f61313f11cb0b40e0310ede4c119467fd/ghc:

Clean up some outdated comments (#8418)

Authored-by: Gergely Risko <gergely@risko.hu>
Signed-off-by: Austin Seipp <austin@well-typed.com>

comment:4 Changed 6 months ago by thoughtpolice

  • Resolution set to fixed
  • Status changed from patch to closed

Merged, thanks!

Note: See TracTickets for help on using tickets.