Opened 9 months ago

Last modified 3 weeks ago

#8379 patch bug

sync-all broken when using the GitHub mirror

Reported by: tibbe Owned by:
Priority: normal Milestone:
Component: Build System Version: 7.7
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Difficulty: Unknown
Test Case: Blocked By:
Blocking: Related Tickets: #8667

Description

Making a fresh checkout using the GitHub mirror:

$ git clone git@github.com:tibbe/ghc.git
$ ./sync-all get
== running git config core.ignorecase true
== running git clone git@github.com:tibbe/ghc-tarballs.git ghc-tarballs
Cloning into 'ghc-tarballs'...
ERROR: Repository not found.
fatal: The remote end hung up unexpectedly
git failed: 32768 at ./sync-all line 178.
== Checking for old haddock repo
== Checking for old binary repo
== Checking for old mtl repo
== Checking for old Cabal repo
== Checking for old time from tarball
============================
ATTENTION!

You have an old time package in your GHC tree!

Please remove it (e.g. "rm -r libraries/time"), and then run
"./sync-all get" to get the new repository.
============================

Attachments (1)

0001-Explain-how-to-clone-GitHub-forks.-Ticket-8379.patch (2.0 KB) - added by thomie 3 weeks ago.
Update README.md

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 months ago by leroux

Oops. This is my fault... Could someone revert 0481e076f3cb4010894324cac71e947c6637805a?

EDIT: Nevermind since this is "sane" and "intended" behavior. Unless otherwise disapprove of it.

Last edited 9 months ago by leroux (previous) (diff)

comment:2 Changed 9 months ago by thoughtpolice

The reason this is happening is because the sync-all script was changed to *properly* clone from GitHub (the original version I wrote was broke.) When you clone from your own fork, it attempts to rewrite submodule URLs to github.com/tibbe/<repo>. You probably don't have these repositories under your account, so it breaks because it can't clone them.

IMO this isn't worth fixing, but perhaps explaining on the wiki - the more 'correct' thing to do (which works) is just always clone/pull from github.com/ghc/ghc and set a remote to point to your forks.

Of course I don't feel very strongly about this and if people want this behavior changed that's fine - but I feel I should point out it sort of didn't work before anyway.

comment:4 Changed 9 months ago by tibbe

  • Resolution set to invalid
  • Status changed from new to closed

Makes sense to me.

comment:5 Changed 3 weeks ago by thomie

Changed 3 weeks ago by thomie

Update README.md

comment:6 Changed 3 weeks ago by thomie

  • Resolution invalid deleted
  • Status changed from closed to new

Since more people seem to run into this, someone please update the README. I added a patch.

comment:7 Changed 3 weeks ago by thomie

  • Status changed from new to patch
Note: See TracTickets for help on using tickets.