Opened 4 years ago

Closed 2 years ago

Last modified 23 months ago

#8292 closed bug (fixed)

linker_unload test doesn't work on Windows

Reported by: ezyang Owned by: ezyang
Priority: normal Milestone: 8.0.1
Component: Test Suite Version: 7.7
Keywords: Cc:
Operating System: Windows Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case: linker_unload
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

I fixed up the major issues but I am getting:

"/c/Users/ezyang/Dev/ghc-dyn/inplace/bin/ghc-stage2.exe" -fforce-recomp -dcore-lint -dcmm-lint 
-dno-debug-output -no-user-package-db -rtsopts  -c Test.hs -v0                                 
# -rtsopts causes a warning                                                                    
"/c/Users/ezyang/Dev/ghc-dyn/inplace/bin/ghc-stage2.exe" -fforce-recomp -dcore-lint -dcmm-lint 
-dno-debug-output -no-user-package-db linker_unload.c -o linker_unload -no-hs-main -optc-Werror
                                                                                               
./linker_unload \Users\ezyang\Dev\ghc-dyn\libraries\base\dist-install\build/libHSbase-4.7.0.0.a
 \Users\ezyang\Dev\ghc-dyn\libraries\ghc-prim\dist-install\build/libHSghc-prim-0.3.1.0.a \Users
\ezyang\Dev\ghc-dyn\libraries\integer-gmp\dist-install\build/libHSinteger-gmp-0.5.1.0.a        
linker_unload.exe: \Users\ezyang\Dev\ghc-dyn\libraries\base\dist-install\build/libHSbase-4.7.0.
0.a: unknown symbol `_select'    

Change History (7)

comment:1 Changed 4 years ago by simonmar

I'm afraid I can't help here - it looks like select might need to be added to RTS_MINGW_ONLY_SYMBOLS, but why for this test and not when GHCi loads the base package? Is there something else we need to load on Windows?

comment:2 Changed 4 years ago by ezyang

That would be my guess. Is there a more "proper" way to get the dependencies you need? I guess that functionality is usually implemented in Haskell-land.

comment:3 Changed 3 years ago by simonmar

I think this might now work on Windows, but someone needs to check: rGHC6108d95a73f93d486223064ad72bf6bedc116cbd

comment:4 Changed 2 years ago by ezyang

Owner: changed from simonmar to ezyang

It does work now! I'll push a commit marking this as passing when I can.

comment:5 Changed 2 years ago by Edward Z. Yang <ezyang@…>

In 7db2dec2cf4fae68f7bb490d7c7780288350b597/ghc:

linker_unload working on Windows, fixes #8292.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

comment:6 Changed 2 years ago by ezyang

Resolution: fixed
Status: newclosed

comment:7 Changed 23 months ago by thomie

Milestone: 8.0.1
Note: See TracTickets for help on using tickets.