Changes between Initial Version and Version 1 of Ticket #8256, comment 11


Ignore:
Timestamp:
Sep 14, 2013 5:41:36 PM (7 months ago)
Author:
thoughtpolice
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #8256, comment 11

    initial v1  
    55As for names? I don't really mind that much. The usage of the 0-3 constants for locality argument comes from GCC, where `__builtin_prefetch` has a locality argument ranging from 0 to 3. There is no real mnemonic here: 3 means it should be left in cache if possible as it has high locality, 0 means it can be evicted after access (low locality,) and 1-2 are just "somewhere inbetween 0 and 3." I imagine LLVM inherited this convention from GCC, and I'm not sure what else we could sensibly call them. 
    66 
    7 That said, we do need a test, and the primops need docs. There are also a lot of typos and random comments laying around which would be nice to get cleaned up (mostly punctuation, stuff like that.) 
     7That said, we do need a test, and the primops need docs. There are also a lot of typos and random comments laying around in the patch which would be nice to get cleaned up (mostly punctuation, stuff like that.)