Changes between Initial Version and Version 1 of Ticket #7918, comment 11


Ignore:
Timestamp:
Sep 3, 2013 10:10:10 AM (19 months ago)
Author:
edsko
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7918, comment 11

    initial v1  
    1 So actually I agreed with you that the special case was undesirable, which is why I had (for types, not yet for expressions) got rid of rnHsType completely, and defined only rnLHsType. This way the exceptions you mention are taken care off statically, which is much better. 
     1So actually I agreed with you that the special case was undesirable, which is why I had (for types, not yet for expressions) got rid of `rnHsType` completely, and defined only `rnLHsType`. This way the exceptions you mention are taken care off statically, which is much better. 
    22 
    3 Your suggestion is an alternative; I thought about it but I thought I'd need to add a new constructor to HsExpr/HsType/Pat/..; didn't realize that I could use the constructor for parens. Do you prefer I use HsPar and co instead of removing rnHsExpr (rnHsType, ..)? It certainly would be a less intrusive change I guess. 
     3Your suggestion is an alternative; I thought about it but I thought I'd need to add a new constructor to `HsExpr`/`HsType`/`Pat`/..; didn't realize that I could use the constructor for parens. Do you prefer I use `HsPar` and co instead of removing `rnHsExpr` (`rnHsType`, ..)? It certainly would be a less intrusive change I guess.