Opened 2 years ago

Closed 15 months ago

#7693 closed feature request (fixed)

Flush .hp file at the end of each sample

Reported by: akio Owned by:
Priority: normal Milestone: 7.6.3
Component: Runtime System Version: 7.7
Keywords: Cc: simonmar
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Revisions:

Description

Tools like hp2any-graph reads a .hp file as it's being written to. However writing to .hp files is currently block-buffered, causing a delay until the latest sample can be read. The attached patch adds a call to fflush every time a complete sample is written.

Attachments (1)

0001-Heap-profiling-flush-.hp-file-at-the-end-of-each-fra.patch (830 bytes) - added by akio 2 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 2 years ago by igloo

  • difficulty set to Unknown
  • Status changed from new to patch

comment:2 Changed 2 years ago by ezyang

  • Status changed from patch to merge

Pushed.

commit b9d537317cb774abf832758e2be9c08db70b6d2c
Author: Takano Akio <[email protected]>
Date:   Fri Feb 15 20:06:38 2013 +0900

    Heap profiling: flush .hp file at the end of each frame

comment:3 Changed 2 years ago by igloo

  • Milestone set to 7.6.3

comment:4 Changed 15 months ago by thoughtpolice

  • Cc simonmar added
  • Resolution set to fixed
  • Status changed from merge to closed

Merged in HEAD/7.8.

Note: See TracTickets for help on using tickets.