Static flags code needs cleanup
|Reported by:||jstolarek||Owned by:||jstolarek|
|Type of failure:||None/Unknown||Test Case:|
|Related Tickets:||Differential Rev(s):|
While reading through the source code I noticed that code responsible for handling static flags could use some refactoring:
- there are two modules that handle static flags: compiler/main/StaticFlags.hs and compiler/main/StaticFlagParser.hs. This is about 300 lines of code total and can be easily placed within a single file, especially that division of functions between these two files is sometimes confusing.
- compiler/main/StaticFlags.hs contains code responsible for handling dynamic flags.
I will merge code from compiler/main/StaticFlagParser.hs into into compiler/main/StaticFlags.hs, create a compiler/main/StaticFlags.hs-boot to break module dependency cycles and move the code for handling dynamic flags to compiler/main/DynFlags.hs
Change History (17)
Changed 4 years ago by jstolarek
comment:6 Changed 3 years ago by igloo
- Milestone set to 7.8.1
- Owner jstolarek deleted
- Priority changed from normal to high
- Resolution fixed deleted
- Status changed from closed to new