Opened 2 years ago

Closed 2 years ago

#7577 closed bug (fixed)

./sync-all doesn't properly detect the existence of the 'time' submodule

Reported by: parcs Owned by:
Priority: normal Milestone:
Component: Build System Version: 7.7
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: Other Test Case:
Blocked By: Blocking:
Related Tickets: Differential Revisions:

Description

The time submodule is present in my repository (at ./libraries/time) but some ./sync-all operations, like ./sync-all fetch, don't seem to detect its presence:

Output from ./sync-all get:

...
Submodule 'libraries/time' () registered for path 'libraries/time'
...
== Checking for old time from tarball

Output from a subsequent ./sync-all fetch:

...
== libraries/time repo not present; skipping
...

./sync-all fetch thinks that the time repo is not present and thus doesn't pull in any updates for it.


This issue is similar to the one which 31d771bec93b17813b03e7a72a586e1f401ef240 fixes.

Attachments (1)

0001-use-e-rather-than-d-when-checking-for-the-existence-.patch (1.1 KB) - added by parcs 2 years ago.
a fix

Download all attachments as: .zip

Change History (4)

comment:1 Changed 2 years ago by parcs

  • Status changed from new to patch

comment:2 Changed 2 years ago by patrick@…

commit 146b0eafa17f0ac28f7ef3f273919c4c6a22f45b

Author: Patrick Palka <[email protected]>
Date:   Sun Jan 13 12:02:10 2013 -0500

    use -e rather than -d when checking for the existence of a subrepo
    
    The .git file in a submodule's root directory is not necessarily a
    directory, as is the case for the 'time' submodule.
    
    This fixes #7577, where some './sync-all' operations don't detect
    that the 'time' submodule is present in the repository.

 sync-all |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

comment:3 Changed 2 years ago by igloo

  • difficulty set to Unknown
  • Resolution set to fixed
  • Status changed from patch to closed

Thanks for the patch; applied.

Note: See TracTickets for help on using tickets.