Opened 3 years ago

Closed 3 years ago

#7573 closed feature request (fixed)

Testsuite should easily be able to compile .cmm files.

Reported by: thoughtpolice Owned by:
Priority: normal Milestone: 7.8.1
Component: Test Suite Version: 7.7
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking: #7571, #7574
Related Tickets: Differential Revisions:

Description

While writing a test for #7571, I found it annoying to have to use multi_compile to just compile cmm code.

I have a patch that adds support for cmm_src modifier for tests. The test for #7571 will depend on this.

Attachments (1)

0001-Add-better-support-for-.cmm-test-files.patch (1.9 KB) - added by thoughtpolice 3 years ago.
Initial patch.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 3 years ago by thoughtpolice

  • Type changed from bug to feature request

Changed 3 years ago by thoughtpolice

Initial patch.

comment:2 Changed 3 years ago by thoughtpolice

  • Status changed from new to patch

comment:3 Changed 3 years ago by thoughtpolice

  • Blocking 7571 added

(In #7571) The attached patch for the testsuite correctly tickles this condition and I've verified it independently on my Mac OS X machine.

commit 62067fcf7dd6b8da9fcc76677a1c1cb59e9eff1d
Author: Austin Seipp <[email protected]>
Date:   Sun Jan 13 03:51:36 2013 -0600

    Test for Trac #7571.
    
    Signed-off-by: Austin Seipp <[email protected]>

The patch depends on the (very simple) testsuite patch I put in #7573. So it's currently blocked.

comment:4 Changed 3 years ago by thoughtpolice

  • Blocking 7574 added

(In #7574) If we want to make a test for this like #7571 (or just reuse it,) we'll need the patch in #7573 too.

comment:5 Changed 3 years ago by simonmar

  • difficulty set to Unknown
  • Milestone set to 7.8.1
  • Owner thoughtpolice deleted
  • Status changed from patch to new

Looks good to me.

comment:6 Changed 3 years ago by thoughtpolice

  • Resolution set to fixed
  • Status changed from new to closed

Closed by

commit 8dbd01a092885ad732bd78ecdebc526088f85a56
Author: Austin Seipp <[email protected]>
Date:   Sun Jan 13 03:41:29 2013 -0600

    Add better support for .cmm test files.
    
    Fixes Trac #7573.
    
    Signed-off-by: Austin Seipp <[email protected]>

I also updated the wiki page about adding tests: http://hackage.haskell.org/trac/ghc/wiki/Building/RunningTests/Adding#Thesetupfield

Note: See TracTickets for help on using tickets.