Instruction list length in bco->instrs redundant
|Reported by:||nomeata||Owned by:|
|Type of failure:||None/Unknown||Test Case:|
|Related Tickets:||Differential Rev(s):|
While reading through the BCO-related code I notice that in the first word of the instruction list of a BCO (bco->instrs->payload), the length of the list (as the multiple of 16-bit-words) is stored. This is used in debugging code, e.g. in the disassembler.
However as far as I can tell this is duplicate information: bco->instrs->bytes already contains this information (as multiple of bytes).
Maybe the instruction list was not a proper StgArrWords object before and this hack was required? If that is the case, I guess it can be removed now, saving a neglectable amount of memory and cleaning the code a bit.
Change History (10)
comment:1 Changed 4 years ago by
|Owner:||set to simonmar|
|Summary:||Instruction list length in bco->instrs redundand → Instruction list length in bco->instrs redundant|