Opened 3 years ago

Last modified 4 months ago

#7285 new feature request

mkWeakMVar is non-compositional

Reported by: edsko Owned by: ekmett
Priority: normal Milestone: 7.12.1
Component: Core Libraries Version: 7.6.1
Keywords: Cc: tkn.akio@…, idhameed@…, simonmar, core-libraries-committee@…
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Revisions:

Description

In base 4.6 addMVarFinalizer is deprecated in favour of mkWeakMVar of type

    mkWeakMVar :: MVar a -> IO () -> IO (Weak (MVar a))

This type makes it inherently non-compositional. For instance, if we have a larger datatype T that contains an MVar somewhere inside then there in no way to define mkWeakT in terms of mkWeakMVar; instead, mkWeakT would have to be defined along the lines of

    mkWeakT :: T a -> IO () -> IO (Weak (T a))
    mkWeakT m@(MkT (MVar m#) _) f = IO $ \s ->
      case mkWeak# m# m f s of (# s1, w #) -> (# s1, Weak w #)

It would be better if the type of mkWeakMVar would change to

    mkWeakMVar :: MVar a -> v -> Maybe (IO ()) -> IO (Weak v)

(i.e., following mkWeak rather than mkWeakPtr).

(The same comment goes for related functions such as mkWeakIORef.)

Change History (8)

comment:1 Changed 3 years ago by akio

  • Cc tkn.akio@… added

comment:2 Changed 3 years ago by igloo

  • difficulty set to Unknown
  • Milestone set to 7.8.1

comment:3 Changed 2 years ago by ihameed

  • Cc idhameed@… added

comment:4 Changed 19 months ago by simonmar

  • Cc simonmar added

comment:5 Changed 12 months ago by thoughtpolice

  • Milestone changed from 7.8.3 to 7.10.1

Moving to 7.10.1

comment:6 Changed 6 months ago by thomie

  • Cc core-libraries-committee@… added
  • Component changed from Compiler to Core Libraries
  • Owner set to ekmett

comment:7 Changed 6 months ago by ekmett

I've sent out a proposal for discussion on libraries@ to seek community feedback, so we can finally clear this out. In general I'm in favor of making the change, though.

comment:8 Changed 4 months ago by thoughtpolice

  • Milestone changed from 7.10.1 to 7.12.1

Moving to 7.12.1 milestone; if you feel this is an error and should be addressed sooner, please move it back to the 7.10.1 milestone.

Note: See TracTickets for help on using tickets.