Opened 4 years ago

Closed 4 years ago

#5457 closed feature request (fixed)

Please whitelist architectures supporting registered builds

Reported by: nomeata Owned by:
Priority: normal Milestone:
Component: Build System Version: 7.2.1
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Revisions:

Description

Hi,

the debian/rules file contains this snippet:

ifneq (,$(findstring $(DEB_HOST_ARCH), i386 amd64 kfreebsd-i386 kfreebsd-amd64 powerpc))
        echo "GhcUnregisterised=NO" >> mk/build.mk
else
        echo "GhcUnregisterised=YES" >> mk/build.mk
endif

which decides whether to do a registered or unregistered build. Obviously, three is nothing Debian specific about it, and it seems to me as if the ghc build system should already know whether a given architecture supports registered builds or not. In fact, in mk/config.mk, I see this code:

ifneq "$(findstring $(HostArch_CPP), alpha hppa)" ""
GhcUnregisterised=YES
else
GhcUnregisterised=NO
endif

Maybe either this list could be extended or, probably more useful, the logic inverted an all architectures _with_ support for registered builds entered.

BTW, OsSupportsGHCi in that file should also include kfreebsdgnu.

Thanks,
Joachim

Change History (1)

comment:1 Changed 4 years ago by simonmar

  • Resolution set to fixed
  • Status changed from new to closed

I fixed this and put the wrong ticket number in the commit, oops.

commit 0f0a3c97101ae7a877b76af4ac02993201c8af09

Author: Simon Marlow <[email protected]>
Date:   Tue Sep 6 14:00:51 2011 +0100

    fix GhcUnregisterised default, and add kfreebsdgnu to OsSupportsGhci
    (#5441)
Note: See TracTickets for help on using tickets.