Opened 4 years ago

Closed 4 years ago

#5349 closed feature request (fixed)

Proposal: Make Q an instance of Applicative

Reported by: basvandijk Owned by:
Priority: normal Milestone:
Component: Template Haskell Version: 7.0.3
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Revisions:

Description

The Q type:

newtype Q a = Q { unQ :: forall m. Quasi m => m a} 

currently has an instance for Monad and Functor. I always find it surprising when a monad doesn't have an Applicative instance. So I would like to propose adding an instance for Applicative as well.

I also propose to make Applicative a superclass of the Quasi class:

class (Monad m, Applicative m, Functor m) => Quasi m where ...

During the discussion on the libraries list Michael Snoyman, Wren ng Thornton and Edward Kmett replied positively. There were no objections.

Attachments (2)

0001-TypeSynonymInstances-are-needed-for-the-Show-instanc.patch (687 bytes) - added by basvandijk 4 years ago.
0002-Make-Q-an-instance-of-Applicative.patch (1.4 KB) - added by basvandijk 4 years ago.

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by basvandijk

comment:1 Changed 4 years ago by simonpj

Just to check, what is lost by this change? Presumably, TH would no longer admit a monad that was not Applicative. Is there any characterisation of what such monads are like? Do we care?

comment:2 Changed 4 years ago by byorgey

Nothing is lost by the change (other than requiring a tiny bit more work on the part of Quasi instances) since all monads are also applicative functors.

However, I note that (Monad m, Applicative m, Functor m) => ... is redundant, since Applicative m requires Functor m. Hence only (Monad m, Applicative m) => ... is needed.

comment:3 Changed 4 years ago by igloo

  • Status changed from new to patch

comment:4 Changed 4 years ago by simonpj

  • Resolution set to fixed
  • Status changed from patch to closed

Right, applied, thank you.

(I did not apply the TypeSynonymInstances patch because I didn't understand what it was about.)

Note: See TracTickets for help on using tickets.