Opened 3 years ago

Closed 2 years ago

#4916 closed bug (fixed)

make clean broken

Reported by: kgardas Owned by: igloo
Priority: normal Milestone: 7.4.1
Component: Build System Version: 7.1
Keywords: Cc:
Operating System: Solaris Architecture: x86
Type of failure: Building GHC failed Difficulty:
Test Case: Blocked By:
Blocking: Related Tickets:

Description

Hello,
it seems `make clean' is broken in ghc head as of Jan 24 2011. The issue looks like:

$ gmake clean
gmake -r --no-print-directory -f ghc.mk clean CLEANING=YES
"rm" -rf inplace/bin inplace/lib
"rm" -rf libraries/dph/dph-base/dist-install
"rm" -rf libraries/dph/dph-prim-interface/dist-install
"rm" -rf libraries/dph/dph-prim-seq/dist-install
"rm" -rf libraries/dph/dph-prim-par/dist-install
rm -rf  libraries/dph/dph-par  libraries/dph/dph-seq
"rm" -rf 
Usage: rm [-cFdfirRuv] file ...
gmake[1]: *** [clean_utils/mkdirhier_] Error 2
gmake: *** [clean] Error 2
$

this is just straight after configure run, but the same result is also obtainable after building whole GHC.

Change History (4)

comment:1 Changed 3 years ago by igloo

  • Milestone set to 7.0.3
  • Owner set to igloo

Thanks for the report.

comment:2 Changed 3 years ago by igloo

  • Milestone changed from 7.2.1 to 7.4.1

comment:3 Changed 2 years ago by igloo@…

commit 80e9070c77718b7ff0e913182e54842754726ce8

Author: Ian Lynagh <igloo@earth.li>
Date:   Sat Nov 19 01:29:05 2011 +0000

    Improve the way we call "rm" in the build system; fixes trac #4916
    
    We avoid calling "rm -rf" with no file arguments; this fixes cleaning
    on Solaris, where that fails.
    
    We also check for suspicious arguments: anything containing "..",
    starting "/", or containing a "*" (you need to call $(wildcard ...)
    yourself now if you really want globbing). This should make things
    a little safer.

 compiler/ghc.mk                |    6 +-
 docs/man/ghc.mk                |    2 +-
 driver/ghci/ghc.mk             |    6 +-
 ghc.mk                         |   91 ++++++++++++++++++++-------------------
 ghc/ghc.mk                     |    4 +-
 includes/ghc.mk                |    2 +-
 libffi/ghc.mk                  |   16 ++++----
 mk/tree.mk                     |   21 +++++++++
 rules/build-dependencies.mk    |    6 +-
 rules/build-package-way.mk     |    4 +-
 rules/build-package.mk         |    4 +-
 rules/build-perl.mk            |    2 +-
 rules/clean-target.mk          |    2 +-
 rules/docbook.mk               |    2 +-
 rules/manual-package-config.mk |    2 +-
 rules/shell-wrapper.mk         |    4 +-
 utils/ghc-pkg/ghc.mk           |   10 ++--
 utils/mkdirhier/ghc.mk         |    2 +-
 utils/runghc/ghc.mk            |    2 +-
 19 files changed, 106 insertions(+), 82 deletions(-)

comment:4 Changed 2 years ago by igloo

  • Resolution set to fixed
  • Status changed from new to closed

Fixed.

Note: See TracTickets for help on using tickets.