Opened 4 years ago

Closed 4 years ago

#4249 closed feature request (fixed)

Remove module from context completion

Reported by: boris Owned by:
Priority: high Milestone: 7.0.1
Component: GHCi Version: 6.13
Keywords: completion module Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Difficulty:
Test Case: Blocked By:
Blocking: Related Tickets:

Description

I propose to suggest in completion only modules the user already loaded into the context. The completion should look like this

Prelude Data.List> :m -
Data.List  Prelude

instead of this

Prelude Data.List> :m -
Display all 728 possibilities? (y or n)

I have already written a patch, but it requires addition of one function into haskeline library. Actually, this function can be put into ghci, but it fits more naturally in haskeline. I have created a ticket in haskeline trac http://trac.haskell.org/haskeline/ticket/109

Attachments (2)

completion.patch (103.2 KB) - added by boris 4 years ago.
completion.2.patch (117.4 KB) - added by boris 4 years ago.
adopted to the new Haskeline

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by boris

comment:1 Changed 4 years ago by simonpj

Sounds good to me (although I am no expert on this part of GHC). I assume we should wait until you have the patch in haskeline; then you can send us a revised patch for GHC if one is needed.

Thanks for doing it.

Simon

comment:2 Changed 4 years ago by igloo

  • Milestone set to 6.14.1
  • Priority changed from normal to high

Haskeline has been patched, but slightly differently, so the patch will need to be adapted slightly.

Should be easy to do, so I've made the ticket high priority so we don't forget.

Changed 4 years ago by boris

adopted to the new Haskeline

comment:3 Changed 4 years ago by boris

  • Status changed from new to patch

comment:4 Changed 4 years ago by igloo

  • Resolution set to fixed
  • Status changed from patch to closed

Applied, thanks!

Note: See TracTickets for help on using tickets.