Opened 8 years ago

Closed 8 years ago

#4122 closed bug (fixed)

Data.Monoid doesn't need to depend on the Prelude

Reported by: tibbe Owned by:
Priority: high Milestone: 7.0.1
Component: libraries/base Version: 6.13
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: Building GHC failed Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

Data.Monoid currently depends on the Prelude, causing an import cycle in the new I/O manager. This patch replaces the dependency on the Prelude with modules in the GHC hierarchy, breaking the cycle.

Attachments (2)

monoid-deps.dpatch (33.7 KB) - added by tibbe 8 years ago.
monoid-deps-revised.dpatch (33.8 KB) - added by tibbe 8 years ago.
Adds -XNoImplicitPrelude

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by tibbe

Attachment: monoid-deps.dpatch added

Changed 8 years ago by tibbe

Attachment: monoid-deps-revised.dpatch added

Adds -XNoImplicitPrelude

comment:1 Changed 8 years ago by tibbe

I've attached a revised patch that adds -XNoImplicitPrelude. The same flag is set in the .cabal file but it doesn't hurt to be explicit.

comment:2 Changed 8 years ago by igloo

Status: newpatch

comment:3 Changed 8 years ago by simonmar

Milestone: 6.14.1
Priority: normalhigh

comment:4 Changed 8 years ago by simonmar

Resolution: fixed
Status: patchclosed

Done. The attached patch depended on a patch by bos that I don't have, so re-recorded as:

Tue Jun 15 11:56:31 BST 2010  Simon Marlow <marlowsd@gmail.com>
  * don't depend on Prelude (#4122)
Note: See TracTickets for help on using tickets.