Opened 8 years ago

Closed 5 years ago

#3940 closed bug (fixed)

Propagate bug fix into new code generator

Reported by: simonpj Owned by:
Priority: low Milestone: 7.6.1
Component: Compiler Version:
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

We must not forget to propagate this fix into the new code generator pipeline:

Thu Mar 25 04:03:28 PDT 2010  Simon Marlow <marlowsd@gmail.com>
  * do_checks: do not set HpAlloc if the stack check fails
  
  This fixes a very rare heap corruption bug, whereby
  
   - a context switch is requested, which sets HpLim to zero
     (contextSwitchCapability(), called by the timer signal or
     another Capability).
  
   - simultaneously a stack check fails, in a code fragment that has
     both a stack and a heap check.
  
  The RTS then assumes that a heap-check failure has occurred and
  subtracts HpAlloc from Hp, although in fact it was a stack-check
  failure and retreating Hp will overwrite valid heap objects.  The bug
  is that HpAlloc should only be set when Hp has been incremented by the
  heap check.  See comments in rts/HeapStackCheck.cmm for more details.
  
  This bug is probably incredibly rare in practice, but I happened to be
  working on a test that triggers it reliably:
  concurrent/should_run/throwto001, compiled with -O -threaded, args 30
  300 +RTS -N2, run repeatedly in a loop.

    M ./compiler/codeGen/CgHeapery.lhs -6 +16

Change History (6)

comment:1 Changed 7 years ago by igloo

Milestone: 6.14 branch6.14.1

comment:2 Changed 7 years ago by igloo

Blocked By: 4258 added

comment:3 Changed 7 years ago by igloo

Milestone: 6.14.16.16.1

comment:4 Changed 6 years ago by igloo

Milestone: 7.4.17.6.1
Priority: normallow

comment:5 Changed 5 years ago by simonmar

Blocked By: 4258 removed
difficulty: Unknown

The new codegen does not have this bug.

comment:6 Changed 5 years ago by simonmar

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.