Opened 6 years ago

Closed 6 years ago

#3035 closed merge (fixed)

:steplocal and :stepmodule should not polute trace history

Reported by: phercek Owned by: igloo
Priority: normal Milestone:
Component: GHCi Version: 6.10.1
Keywords: debugger Cc: phercek@…, mnislaih@…
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: Test Case:
Blocked By: Blocking:
Related Tickets: Differential Revisions:

Description

:steplocal and :stepmodule should not extend trace history with records which represent breakpoints outside the scopes in which :steplocal and :stepmodule are actually stopping.

For some discussion related to this see
http://www.haskell.org/pipermail/glasgow-haskell-users/2009-February/016576.html

Attachments (2)

traceOnlyStops.dpatch (35.9 KB) - added by phercek 6 years ago.
the patch fixing this ticket
traceOnlyStops.patch (3.5 KB) - added by phercek 6 years ago.
unified diff version of the patch (aganist ghc version from 2009-02-11 at http://darcs.haskell.org/ghc-6.10/ghc)

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by phercek

the patch fixing this ticket

comment:1 Changed 6 years ago by mnislaih

  • Cc phercek@… mnislaih@… added
  • Owner set to mnislaih
  • Status changed from new to assigned

Peter, this patch is against HEAD, right ?
It looks like cannot apply it because of a darcs bug. *Sigh*

After trying both with darcs1 and darcs2 on a clean ghc, I give up.
Would you mind to attach a manual patch instead?

Thanks.

pepe@ender4:~/scratch/ghc.head$ darcs1 apply ../ghc.phercek/traceOnlyStops.dpatch 
darcs1: bug in get_extra commuting patch:
Sat Sep 20 17:57:22 CEST 2008  Ian Lynagh <[email protected]>
  * Add library release notes

Changed 6 years ago by phercek

unified diff version of the patch (aganist ghc version from 2009-02-11 at http://darcs.haskell.org/ghc-6.10/ghc)

comment:2 Changed 6 years ago by mnislaih

  • Owner changed from mnislaih to Igloo
  • Status changed from assigned to new
  • Type changed from bug to merge

Validated and pushed

Sun Feb 22 21:10:02 CET 2009  Peter Hercek <[email protected]>
  * :steplocal and :stepmodule should not polute trace history

This patch can be merged to ghc-6.10 if the API change in GhciMonad.resume is not too bad.

comment:3 Changed 6 years ago by mnislaih

  • Owner changed from Igloo to igloo

comment:4 Changed 6 years ago by igloo

  • difficulty set to Unknown
  • Resolution set to fixed
  • Status changed from new to closed

Merged

Note: See TracTickets for help on using tickets.