Opened 6 years ago

Closed 15 months ago

#2548 closed feature request (wontfix)

validate should continue if it sees warnings or haddock failures

Reported by: igloo Owned by:
Priority: lowest Milestone: 7.6.2
Component: Build System Version: 6.8.3
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Difficulty: Unknown
Test Case: Blocked By:
Blocking: Related Tickets:

Description

From this thread:
http://www.haskell.org/pipermail/cvs-ghc/2008-August/044517.html

Rather than falling over on warnings and haddock failures, validate should just report them at the end, e.g.:

Unexpected warnings in modules:
        simplCore/Simplify.lhs
        codeGen/CgMonad.lhs

Unexpected Haddock failure in:
        codeGen/CgExpr.lhs

Unexpected testsuite failures in:
        tc125

Change History (12)

comment:1 Changed 6 years ago by simonmar

  • Architecture changed from Unknown to Unknown/Multiple

comment:2 Changed 6 years ago by simonmar

  • Operating System changed from Unknown to Unknown/Multiple

comment:3 Changed 4 years ago by igloo

  • Milestone changed from 6.12 branch to 6.12.3

comment:4 Changed 4 years ago by igloo

  • Milestone changed from 6.12.3 to 6.14.1
  • Priority changed from normal to low

comment:5 Changed 4 years ago by igloo

  • Type of failure set to None/Unknown

I think we'd want "ghc -Werror" to complete (#1666) and fail with a particular exit code, so that we can detect it in the build system.

comment:6 Changed 3 years ago by igloo

  • Milestone changed from 7.0.1 to 7.0.2

comment:7 Changed 3 years ago by igloo

  • Milestone changed from 7.0.2 to 7.2.1

comment:8 Changed 3 years ago by igloo

  • Milestone changed from 7.2.1 to 7.4.1

comment:9 Changed 2 years ago by igloo

  • Milestone changed from 7.4.1 to 7.6.1
  • Priority changed from low to lowest

comment:10 Changed 20 months ago by igloo

  • Milestone changed from 7.6.1 to 7.6.2

comment:11 Changed 15 months ago by morabbin

This seems fixed now?

comment:12 Changed 15 months ago by simonmar

  • Resolution set to wontfix
  • Status changed from new to closed

Not fixed, but IMO I don't think we want this. Right now if there's a warning you have to fix it right away, but changing it into a gently nudge at the end might give us the same problem we have with testsuite failures - it's too easy to ignore them and push anyway.

Note: See TracTickets for help on using tickets.