Opened 2 months ago

Last modified 4 weeks ago

#16043 new bug

Lots of testsuite output breaks with integer-simple

Reported by: bgamari Owned by:
Priority: normal Milestone:
Component: Compiler Version: 8.6.3
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: #16091 Differential Rev(s):
Wiki Page:

Description

Numerous testsuite tests assume that we are using integer-gmp. This assumption mostly arises due to the lack of support for integer-simple Integers in RtClosureInspect.cPprTermBase, causing many GHCi tests to break. I have marked these as broken to make progress on #15915.

Change History (7)

comment:1 Changed 2 months ago by Ben Gamari <ben@…>

In 14500da/ghc:

testsuite: Fix a number of GHCi-related failures due to integer-simple

Towards fixing #16043.

comment:2 Changed 2 months ago by Ben Gamari <ben@…>

In 9d9f4c9/ghc:

testsuite: Normalise away spurious differences in out-of-scope instances

This fixes a variety of testsuite failures with integer-simple of the form

```
--- typecheck/should_fail/tcfail072.run/tcfail072.stderr.normalised
+++ typecheck/should_fail/tcfail072.run/tcfail072.comp.stderr.normalised
@@ -12,7 +12,7 @@
           -- Defined in ‘integer-<IMPL>-<VERSION>:GHC.Integer.Type’
         instance Ord () -- Defined in ‘GHC.Classes’
         ...plus 21 others
-        ...plus three instances involving out-of-scope types
+        ...plus two instances involving out-of-scope types
         (use -fprint-potential-instances to see them all)
      In the expression: g A
       In an equation for ‘g’: g (B _ _) = g A
```

In service of fixing #16043.

comment:3 Changed 2 months ago by Ben Gamari <ben@…>

In cd4477c9/ghc:

testsuite: Normalise away package name differences from safePkg01

Spurious changes observed in a integer-simple build. In service of #16043.

comment:4 Changed 8 weeks ago by Ben Gamari <ben@…>

In e59439af/ghc:

testsuite: Fix broken_without_gmp

The lack of types made the previous failure silent, sadly. Improves
situation of #16043.

comment:5 Changed 8 weeks ago by bgamari

I have found that arith011 fails under integer-simple in a way that suggests a behavioral difference between integer-simple and integer-gmp. I've opened #16091 to track this.

comment:6 Changed 8 weeks ago by Ben Gamari <ben@…>

In 9937820/ghc:

testsuite: Fix a variety of issues when building with integer-simple

 * Mark arith011 as broken with integer-simple

   As noted in #16091, arith011 fails when run against integer-simple with a
   "divide by zero" exception. This suggests that integer-gmp and integer-simple
   are handling division by zero differently.

 * This also fixes broken_without_gmp; the lack of types made the previous
   failure silent, sadly. Improves situation of #16043.

 * Mark several tests implicitly depending upon integer-gmp as broken
   with integer-simple. These expect to see Core coming from integer-gmp,
   which breaks with integer-simple.

 * Increase runtime timeout multiplier of T11627a with integer-simple

   I previously saw that T11627a timed out in all profiling ways when run against
   integer-simple. I suspect this is due to integer-simple's rather verbose heap
   representation. Let's see whether increasing the runtime timeout helps.

   Fixes test for #11627.

This is all in service of fixing #16043.

comment:7 Changed 4 weeks ago by bgamari

d2eb344a38f6c727040ba76e584aeaca8e8aefb3 went a long ways towards fixing the remaining issues.

Note: See TracTickets for help on using tickets.