Opened 2 months ago

Closed 2 months ago

#15995 closed feature request (fixed)

Make Control.Concurrent.QSem a newtype

Reported by: chessai Owned by:
Priority: normal Milestone: 8.8.1
Component: libraries/base Version: 8.6.2
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

data QSem = QSem !(MVar (Int, [MVar ()], [MVar ()]))

I think this should be a newtype. The strictness annotations on the outter MVar could just be at each site where pattern matching on the QSem.

Change History (4)

comment:1 Changed 2 months ago by chessai

this goes for QSemN too.

comment:2 Changed 2 months ago by bgamari

Milestone: 8.6.3

Ticket retargeted after milestone closed

comment:3 Changed 2 months ago by Ben Gamari <ben@…>

In f5e98bb/ghc:

make QSem and QSemN newtypes

Reviewers: RyanGlScott, ekmett, hvr, bgamari

Reviewed By: bgamari

Subscribers: rwbarton, carter

GHC Trac Issues: #15995

Differential Revision: https://phabricator.haskell.org/D5456

comment:4 Changed 2 months ago by bgamari

Milestone: 8.8.1
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.