Opened 2 weeks ago

Last modified 10 days ago

#14525 patch bug

Backpack doesn't work with CPP

Reported by: ezyang Owned by:
Priority: normal Milestone:
Component: Compiler Version: 8.2.2
Keywords: backpack Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s): Phab:D4234
Wiki Page:

Description

Steps to repro:

  1. Create a package with a signature and a module which imports it
  2. Add {-# LANGUAGE CPP #-} to the module

Expected result: it works

Actual result:

<command line>: unknown package: hole

Change History (2)

comment:1 Changed 2 weeks ago by ezyang

Differential Rev(s): Phab:D4234
Status: newpatch

comment:2 Changed 10 days ago by Edward Z. Yang <ezyang@…>

In e1fb283/ghc:

Handle CPP properly in Backpack

Summary:
Previously, we attempted to lookup 'hole' packages for
include directories; this obviously is not going to work.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Test Plan: validate

Reviewers: ekmett, bgamari

Subscribers: rwbarton, thomie

GHC Trac Issues: #14525

Differential Revision: https://phabricator.haskell.org/D4234
Note: See TracTickets for help on using tickets.