Opened 10 years ago

Closed 5 years ago

#1298 closed bug (invalid)

Data.Complex.phase does unnecessary pattern match

Reported by: guest Owned by:
Priority: normal Milestone:
Component: Prelude Version: 6.7
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:


The Data.Complex.phase function contains this line: phase (0 :+ 0) = 0 -- SLPJ July 97 from John Peterson

This is not necessary since atan2 (invoked on the following line) is defined such that it returns 0 in this case already.

-- Lennart

Change History (5)

comment:1 Changed 10 years ago by igloo

Milestone: _|_

comment:2 Changed 9 years ago by simonmar

Architecture: UnknownUnknown/Multiple

comment:3 Changed 9 years ago by simonmar

Operating System: UnknownUnknown/Multiple

comment:4 Changed 5 years ago by morabbin

Type of failure: None/Unknown

Since it's not GHC-specific (see Ian's comment above), close as invalid?

comment:5 Changed 5 years ago by igloo

Resolution: invalid
Status: newclosed

Yeah, I'll close this. Anyone interested in seeing it happen, please propose it on the list as per the policy.

Note: See TracTickets for help on using tickets.