Opened 3 years ago

Closed 3 years ago

#10911 closed bug (fixed)

Allow left ∨ (+++) as minimal definition of ArrowChoice instance

Reported by: mfdyck.google Owned by:
Priority: normal Milestone: 8.0.1
Component: Core Libraries Version: 7.10.2
Keywords: Cc: ekmett
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

Add default definitions of left, right in terms of (+++) to let one define an ArrowChoice instance in terms of (+++) rather than left, which is sometimes more elegant or convenient.

Attachments (2)

0001-unbreak-Text.Read.Lex.lex.patch​ (1.9 KB) - added by mfdyck.google 3 years ago.
Behave as GHC lexer
0001-Allow-left-as-minimal-definition-of-ArrowChoice-inst.patch​ (2.0 KB) - added by mfdyck.google 3 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 3 years ago by mfdyck.google

Patch written; awaiting its release

Changed 3 years ago by mfdyck.google

Attachment: 0001-unbreak-Text.Read.Lex.lex.patch​ added

Behave as GHC lexer

comment:2 Changed 3 years ago by mfdyck.google

Whoops, sorry, wrong patch

Changed 3 years ago by mfdyck.google

Attachment: 0001-Allow-left-as-minimal-definition-of-ArrowChoice-inst.patch​ added

comment:3 Changed 3 years ago by mfdyck.google

Status: new → patch

comment:4 Changed 3 years ago by ekmett

Sounds good to me. We just accepted a similar patch to the main Arrow type.

comment:5 Changed 3 years ago by ekmett

The MINIMAL pragma would also be affected.

comment:6 Changed 3 years ago by Austin Seipp <austin@…>

In 6a8ca650/ghc: 

Allow left ∨ (+++) as minimal definition of ArrowChoice instance

See #10911.

Reviewers: ekmett

Signed-off-by: Austin Seipp <austin@well-typed.com>

comment:7 Changed 3 years ago by thoughtpolice

Resolution: → fixed
Status: patch → closed

Merged, thanks!

Note: See TracTickets for help on using tickets.