Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#10834 closed bug (fixed)

Test suite: Resistance against CallStack line number changes

Reported by: nomeata Owned by:
Priority: normal Milestone: 8.0.1
Component: Test Suite Version: 7.10.2
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Phab:D1206 Differential Rev(s):
Wiki Page:

Description

Hi,

I just got this:

Actual stderr output differs from expected:
--- ./ghci/scripts/T10501.stderr.normalised	2015-09-03 00:20:22.622940998 +0000
+++ ./ghci/scripts/T10501.run.stderr.normalised	2015-09-03 00:20:22.622940998 +0000
@@ -1,6 +1,6 @@
 *** Exception: Prelude.head: empty list
 CallStack:
-  error, called at libraries/base/GHC/List.hs:1009:3 in base:GHC.List
+  error, called at libraries/base/GHC/List.hs:1011:3 in base:GHC.List
 *** Exception: Prelude.undefined
 CallStack:
   error, called at libraries/base/GHC/Err.hs:42:14 in base:GHC.Err
*** unexpected failure for T10501(ghci)

Having the test suite so fragile is annoying. Would it be possible to ignore line number differences in call stacks?

Change History (5)

comment:1 Changed 2 years ago by thomie

Status: newpatch

comment:2 Changed 2 years ago by nomeata

Heh, I knew I could rely on you, thomie. Thanks!

comment:3 Changed 2 years ago by Thomas Miedema <thomasmiedema@…>

In 79cdb25/ghc:

Testsuite: ignore line number differences in call stacks (#10834)

Differential Revision: https://phabricator.haskell.org/D1206

comment:4 Changed 2 years ago by thomie

Milestone: 7.12.1
Resolution: fixed
Status: patchclosed

comment:5 Changed 2 years ago by thoughtpolice

Milestone: 7.12.18.0.1

Milestone renamed

Note: See TracTickets for help on using tickets.