Smooth out the differences between `compiler/utils/Pretty.hs` and `libraries/pretty`
|Reported by:||thomie||Owned by:|
|Type of failure:||None/Unknown||Test Case:|
|Related Tickets:||#1062, #1176, #7666, #8809||Differential Rev(s):||Phab:D1130, Phab:D1132|
GHC has an internal copy of
- refactor GHC's copy to make it as similar as possible to
pretty, without making any real code changes.
- apply the bug fixes that
prettyreceived to GHC's copy, making sure not to pick up any possible new bugs in the process.
According to (1):
"There is one situation where the laws for pretty are ambiguous and leave room for choice. GHC decided one way and pretty the other."
- Find which law that is, and document the differences.
Ideally we could remove GHC's copy altogether, but we're not there yet. GHC's copy uses FastString, which is supposedly needed for performance, whereas pretty uses
Change History (26)
comment:3 Changed 20 months ago by
|Related Tickets:||#1062, #1176, #7666 → #1062, #1176, #7666, #8809|
comment:14 Changed 20 months ago by
|Differential Rev(s):||Phab:D1130 → Phab:D1130, Phab:D1132|
|Status:||new → patch|
comment:23 Changed 14 months ago by
|Milestone:||8.2.1 → 8.0.1|
|Status:||patch → closed|