Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#10410 closed bug (fixed)

make install installs haddck.t files

Reported by: nomeata Owned by:
Priority: normal Milestone: 8.0.1
Component: Build System Version: 7.10.1
Keywords: Cc: juhpetersen
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s): Phab:903
Wiki Page:

Description

Since changeset:55cdcc96/ghc, building GHC creates .haddock.t files with statistics. I’m not sure how useful they are in general, but they are definitely not useful in release tarballs.

Currently, make install copies them. This affects both the binary release on the ghc page as well as distribution packages (checked Debian and Fedora).

It seems these files are used by the test suite (testsuite/tests/perf/haddock/all.T), so probably make install should be taught to ignore them.

Change History (4)

comment:1 Changed 3 years ago by thomie

Differential Rev(s): Phab:903
Status: newpatch

comment:2 Changed 2 years ago by Thomas Miedema <thomasmiedema@…>

In 388448bcc2e363d1913b5132a36ac7aaa20eafc0/ghc:

Build system: don't install haddock .t files (#10410)

When generating a haddock .t file for a library, don't save it in the
`dist-install/doc` directory for that library, as then it gets copied to
the installation directory during `make install` by `ghc-cabal copy`.
Instead, save it a few directories up; putting it next to
`haddock-prologue.txt` seemed appropriate.

Test Plan: run `make` in `tests/perf/haddock`.

Differential Revision: https://phabricator.haskell.org/D903

comment:3 Changed 2 years ago by thomie

Milestone: 7.12.1
Resolution: fixed
Status: patchclosed

comment:4 Changed 2 years ago by thoughtpolice

Milestone: 7.12.18.0.1

Milestone renamed

Note: See TracTickets for help on using tickets.