Opened 3 years ago

Closed 2 years ago

#10406 closed bug (fixed)

ghc-7.10.1-testsuite.tar.xz [4.3MB] contains x86_64 ghc-config executable!

Reported by: juhpetersen Owned by:
Priority: normal Milestone: 7.10.2
Component: Build System Version: 7.10.1
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: x86
Type of failure: Building GHC failed Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s): Phab:D956
Wiki Page:

Description

I didn't check ghc-7.10.1-testsuite.tar.bz2 but at least ghc-7.10.1-testsuite.tar.xz contains testsuite/mk/ghc-config which is a 64bit Linux executable.

This causes the testsuite to fail on non-x86_64 arches eg i686 Linux, etc since it can't be executed.

A workaround is to rm testsuite/mk/ghc-config.

It would be good to avoid this for 7.10.2.

Change History (6)

comment:1 Changed 2 years ago by thoughtpolice

Differential Rev(s): Phab:D956
Status: newpatch

comment:2 Changed 2 years ago by Austin Seipp <austin@…>

In a48167eaaa984fbdc1ad31c2c674058ba3669ac6/ghc:

build: Clean testsuite before sdist

When making the `sdist` tarball, we don't really need anything inside
$(TOP)/testsuite in order to do our thing. So make sure we clean it
first to avoid situations like #10406.

With D917 landed, this can actually avoided entirely by fixing the
official release process to instead build an `sdist` //first// from the
clean git repository and then build that (to fixpoint) and test it. Then
the originall clean tarball can be shipped.

But it's nice to be safe in the general case where someone might want to
(in the future) `sdist` out of their build tree.

Signed-off-by: Austin Seipp <austin@well-typed.com>

Reviewed By: thomie

Differential Revision: https://phabricator.haskell.org/D956

GHC Trac Issues: #10406

comment:3 Changed 2 years ago by thoughtpolice

Resolution: fixed
Status: patchclosed

Merged to ghc-7.10.

comment:4 Changed 2 years ago by Thomas Miedema <thomasmiedema@…>

In 5828457d8d26fd33130d4b5850847c9a73a8d3e5/ghc:

make sdist: distclean testsuite for real (#10406)

comment:5 Changed 2 years ago by thomie

Status: closedmerge

Fix up previous commit.

Edit: I tested it.

Last edited 2 years ago by thomie (previous) (diff)

comment:6 Changed 2 years ago by thoughtpolice

Status: mergeclosed

Already merged, thanks Thomas!

Note: See TracTickets for help on using tickets.