Opened 3 years ago

Closed 2 years ago

#10399 closed bug (fixed)

ApiAnnotations tweaks

Reported by: alanz Owned by: alanz
Priority: normal Milestone: 7.10.2
Component: Compiler Version: 7.10.1
Keywords: ApiAnnotations Cc: mpickering
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s): Phab:D901
Wiki Page:

Description (last modified by alanz)

A collection of minor updates for the API Annotations.

  1. The annotations for the implicity parameter is disconnected in the following
type MPI = ?mpi_secret :: MPISecret
  1. In the following, the annotation for one of the commas is disconeected.
mkPoli = mkBila . map ((,,(),,()) <$> P.base <*> P.pos <*> P.form)
  1. In the following, the annotation for the parens becomes disconnected
data MaybeDefault v where
    SetTo :: forall v . ( Eq v, Show v ) => !v -> MaybeDefault v
    SetTo4 :: forall v a. (( Eq v, Show v ) => v -> MaybeDefault v -> a -> MaybeDefault [a])

Change History (6)

comment:1 Changed 3 years ago by alanz

Description: modified (diff)

comment:2 Changed 3 years ago by alanz

Description: modified (diff)

comment:3 Changed 3 years ago by alanz

Differential Rev(s): Phab:D901
Status: newpatch

comment:4 Changed 3 years ago by Alan Zimmerman <alan.zimm@…>

In c5911479f295242e16e396eb5d1369f2e4ce8de0/ghc:

ApiAnnotations tweaks

Summary:
A collection of minor updates for the API Annotations.

1. The annotations for the implicity parameter is disconnected in the
   following

    type MPI = ?mpi_secret :: MPISecret

2. In the following, the annotation for one of the commas is disconeected.

    mkPoli = mkBila . map ((,,(),,()) <$> P.base <*> P.pos <*> P.form)

3. In the following, the annotation for the parens becomes disconnected

    data MaybeDefault v where
        SetTo :: forall v . ( Eq v, Show v ) => !v -> MaybeDefault v
        SetTo4 :: forall v a. (( Eq v, Show v ) => v -> MaybeDefault v
                                                -> a -> MaybeDefault [a])

Test Plan: ./validate

Reviewers: hvr, austin

Reviewed By: austin

Subscribers: bgamari, thomie, mpickering

Differential Revision: https://phabricator.haskell.org/D901

GHC Trac Issues: #10399

comment:5 Changed 3 years ago by thoughtpolice

Status: patchmerge

comment:6 Changed 2 years ago by thoughtpolice

Resolution: fixed
Status: mergeclosed

Merged to ghc-7.10.

Note: See TracTickets for help on using tickets.