Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#10261 closed bug (fixed)

Don't build runghc if we don't have GhcWithInterpreter

Reported by: rwbarton Owned by:
Priority: low Milestone: 8.0.1
Component: Build System Version: 7.10.1
Keywords: newcomer Cc: gidyn
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s): Phab:D920
Wiki Page:

Description

On configurations with GhcWithInterpreter=NO, we should not build runghc (since it will never work), and especially not install runghc/runhaskell scripts/symlinks when the system might already have another working runhaskell (e.g., Hugs).

Change History (6)

comment:1 Changed 3 years ago by gidyn

Cc: gidyn added

comment:2 Changed 3 years ago by rwbarton

Keywords: newcomer added

This might be quite easy, or not.

comment:3 Changed 2 years ago by thomie

Differential Rev(s): Phab:D920
Milestone: 7.12.1
Status: newpatch

Easy indeed.

comment:4 Changed 2 years ago by Thomas Miedema <thomasmiedema@…>

In 508a3a33988d2872f580d8b727036f7f443d8b6d/ghc:

Build system: don't build runghc if GhcWithInterpreter=NO (#10261)

To test:
  * run `make clean` in utils/runghc
  * make sure inplace/bin doesn't contain runghc
  * set GhcWithInterpreter=NO in build.mk
  * run `make`
  * note that inplace/bin doesn't contain runghc

It won't be installed either, nor will runhaskell.

Differential Revision: https://phabricator.haskell.org/D920

comment:5 Changed 2 years ago by thomie

Resolution: fixed
Status: patchclosed

comment:6 Changed 2 years ago by thoughtpolice

Milestone: 7.12.18.0.1

Milestone renamed

Note: See TracTickets for help on using tickets.