Opened 3 years ago

Closed 3 years ago

Last modified 23 months ago

#10186 closed task (fixed)

exprIsBottom should include isEmptyTy

Reported by: nomeata Owned by: nomeata
Priority: normal Milestone: 8.0.1
Component: Compiler Version: 7.8.4
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

This is a spin-of of comment:3:ticket:10180: exprIsBottom (which currently only takes strictnes signatures into account) should also look at the type, via the new isEmptyTy.

Change History (4)

comment:1 Changed 3 years ago by nomeata

I created a DR for this very small change, basically as a quick way to get a validate run started before I go to bed :-) Phab:D754

comment:2 Changed 3 years ago by Joachim Breitner <mail@…>

In 7062ebe0ce92c191d87e993bd2497275976b9452/ghc:

exprIsBottom: Make use of isEmptyTy (#10186)

Any expression with of empty type is necessary bottom, so we can use
that here. No effects known, but it is the right thing to do and
validate, so lets do it.

Differential Revision: https://phabricator.haskell.org/D754

comment:3 Changed 3 years ago by nomeata

Resolution: fixed
Status: newclosed

Makes sense and validates; pushed.

comment:4 Changed 23 months ago by thomie

Milestone: 8.0.1
Note: See TracTickets for help on using tickets.