Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#10157 closed bug (fixed)

HSCOLOUR_SRCS=YES fails mysteriously when no HsColour executable available

Reported by: ezyang Owned by:
Priority: low Milestone: 8.0.1
Component: Build System Version: 7.11
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s): Phab:D1232
Wiki Page:

Description

We seem to fill in the --with-hscolour= flag with an empty string, which causes a plain old build failure. Configure probably ought to fail if HSCOLOUR_SRCS=YES and there is no hscolours.

Change History (4)

comment:1 Changed 2 years ago by thomie

Differential Rev(s): Phab:D1232
Milestone: 7.12.1
Status: newpatch

comment:2 Changed 2 years ago by Thomas Miedema <thomasmiedema@…>

In 1b8eca18/ghc:

Build system: check for inconsistent settings (#10157)

`configure` currently detects when the docbook and hscolour tools aren't
available, and instead of failing outright (as it does for missing alex
and happy), sets some variables in mk/config.mk to tell `make` not to
build the documentation.

Sometimes, however, you want to really make sure all documentation gets
built, fully colourized. For example when making a release. To do so,
you can override the mentioned variables from mk/config.mk in
mk/build.mk (e.g. set HSCOLOUR_SRCS=YES).

This patch adds some error checking to make sure that doing so will not
result in weird build failures when those tools are still missing.

Test Plan: ran `make` a couple of times, with different mk/config.mk settings.

Reviewed by: austin

Differential Revision: https://phabricator.haskell.org/D1232

comment:3 Changed 2 years ago by thomie

Resolution: fixed
Status: patchclosed

comment:4 Changed 2 years ago by thoughtpolice

Milestone: 7.12.18.0.1

Milestone renamed

Note: See TracTickets for help on using tickets.