Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#10138 closed bug (fixed)

hpc does not handle absolute paths correctly

Reported by: thomie Owned by:
Priority: normal Milestone: 8.0.1
Component: Code Coverage Version: 7.8.4
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case: hpc/T10138
Blocked By: Blocking:
Related Tickets: Differential Rev(s): Phab:D703
Wiki Page:

Change History (4)

comment:1 Changed 3 years ago by thomie

Differential Rev(s): Phab:D703
Milestone: 7.12.1
Status: newpatch
Test Case: hpc/T10138

comment:2 Changed 3 years ago by Thomas Miedema <thomasmiedema@…>

In 801f4b98fa5198ab7e033949dd84aaae00162993/ghc:

hpc: use System.FilePath.(</>) instead of (++)

Summary:
BAD: "." ++ "/" ++ "/absolute/path" == ".//absolute/path"
GOOD: "." </> "/absolute/path" == "/absolute path"

Also replace `++ ".ext"` with `<.> "ext"`. Although it doesn't fix any
bugs in this instance, it might in some other. As a general rule it's
better not to use (++) on FilePaths.

Reviewed By: austin, hvr

Differential Revision: https://phabricator.haskell.org/D703

GHC Trac Issues: #10138

comment:3 Changed 3 years ago by thomie

Resolution: fixed
Status: patchclosed

comment:4 Changed 2 years ago by thoughtpolice

Milestone: 7.12.18.0.1

Milestone renamed

Note: See TracTickets for help on using tickets.