Opened 3 years ago

Closed 2 years ago

#10033 closed bug (worksforme)

Can't push to `wip/...` branches because of pre-commit check

Reported by: goldfire Owned by:
Priority: normal Milestone:
Component: Trac & Git Version: 7.8.4
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Test Case:
Blocked By: Blocking:
Related Tickets: Differential Rev(s):
Wiki Page:

Description

I made some edits on my wip/rae branch and tried to push to the remote wip/rae branch. But I see this:

11:42:05 ~/Documents/Programming/ghc-cur> git push -u origin wip/rae --force
Counting objects: 5, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 580 bytes | 0 bytes/s, done.
Total 5 (delta 4), reused 0 (delta 0)
remote: performing tab-check...
remote: Error: you may not add a line containing a tab to these tab-free files:
remote: 	testsuite/tests/rename/should_fail/Makefile
To ssh://git@git.haskell.org/ghc.git
 ! [remote rejected] wip/rae -> wip/rae (pre-receive hook declined)
error: failed to push some refs to 'ssh://git@git.haskell.org/ghc.git'

There are two problems here:

  1. I didn't change testsuite/tests/rename/should_fail/Makefile!
  2. Makefiles like having tabs in them.

Change History (1)

comment:1 Changed 2 years ago by thomie

Resolution: worksforme
Status: newclosed

I'm going to assume this is fixed, or there would be many more reports of it.

Note: See TracTickets for help on using tickets.