Duplicate record field

This compiles.

data D = D1 { f1 :: Int }
       | D2 { f1, f1 :: Int } -- Oops, duplicate

Probably harmless, but still.

Trac metadata

Trac field	Value
Version	7.8.2
Type	Bug
TypeOfFailure	OtherFailure
Priority	low
Resolution	Unresolved
Component	Compiler
Test case
Differential revisions
BlockedBy
Related
Blocking
CC
Operating system
Architecture

changed weight to 3

added Tbug Trac import labels

Trac metadata

Trac field	Value
TypeOfFailure	OtherFailure → InvalidProgramAccepted

assigned to @trac-gintas

Trac metadata

Trac field	Value
Test case	→ T9156

Attached file 0001-Fixed-issue-with-detection-of-duplicate-record-field.patch (download).

Wait, some performance tests are failing, I don't think they're flukes.

OK, the failures do look like a fluke, although I'm not quite sure. Could someone take a look?

Trac metadata

Trac field	Value
CC	→ nomeata

Attached file 0002-Refactored-record-field-duplicate-code-to-use-nested.patch (download).

The 0002-Refactored-record-field-duplicate-code-to-use-nested.patch is broken, I accidentally uploaded a stale version. Sorry about that. Use 0002-fixed-refactor.patch instead.

Attached file 0002-fixed-refactor.patch (download).

The patch should be good to apply. Could someone take a closer look?

Sorry for the delay.

The refactoring patch lost your comment, and I believe the code could use some comments.

Also, your dropOneUnloc (unloc v) could be a deleteBy (\v' -> unloc v == unloc v') or deleteBy ((==) on unloc), unless I’m mistaken. This would make the code a tad smaller and easier to read (assuming you add a comment that states that it is important here that deleteBy deletes only the first occurence).

Very minor, but I slightly tripped over (L loc name : r') ++ go remSeen' rs, and would not have tripped over (L loc name) : r' ++ go remSeen' rs.

Attached file 0002-fixed-refactor-with-comment.patch (download).

Updated patch

Re-added the comment and fixed the cosmetic issues you mentioned, please take a look. Thanks.

Looks good to me. I think I’ll try to create a Pharicator code review thingy tomorrow, just to get used to the new tool.

Trac metadata

Trac field	Value
Differential revisions	→ D87

mentioned in commit d2942184

Applied. Sorry, Gintautas, for the delay and thanks for your second contribution to GHC! I hope there will be more to come :-)

closed

Trac metadata

Trac field	Value
Resolution	Unresolved → ResolvedFixed

mentioned in issue #10591 (closed)

added Plow label

mentioned in commit e23604e9

mentioned in commit 4ff3c565

mentioned in commit 56ef380c

mentioned in commit 84160a65

marked this issue as related to #19287 (closed)