GHCi leaks in DEBUG mode

The solution to ticket #15111 (closed) fixes some space leaks in GHCi. That ticket also installs -fghci-leak-check to the testsuite, so that we'll know when these leaks return. This is all good.

However, the DEBUG compile still leaks in GHCi. This means that many ghci tests fail in the testsuite when using a DEBUG compiler.

I thus have two requests:

1. (hopefully quick) Teach the testsuite not to use -fghci-leak-check on a DEBUG compiler. I tried to do this myself but got lost, never having worked on the testsuite harness.
2. Fix the leaks.

If someone could post the fix to (1) in the short term (even if you don't commit it), I'd be grateful. This is holding me up.

Trac metadata

Trac field	Value
Version	8.4.3
Type	Bug
TypeOfFailure	OtherFailure
Priority	normal
Resolution	Unresolved
Component	Compiler
Test case
Differential revisions
BlockedBy
Related
Blocking
CC
Operating system
Architecture

mentioned in issue #15246 (closed)

changed milestone to %8.6.1

changed weight to 5

added Tbug Trac import labels

Trac metadata

Trac field	Value
Related	- → #15246 (closed)

Try this?

diff --git a/testsuite/config/ghc b/testsuite/config/ghc
index f41f372..dde5bac 100644
--- a/testsuite/config/ghc
+++ b/testsuite/config/ghc
@@ -80,7 +80,7 @@ config.way_flags = {
     'prof_no_auto' : ['-prof', '-static', '-fasm'],
     'profasm'      : ['-O', '-prof', '-static', '-fprof-auto'],
     'profthreaded' : ['-O', '-prof', '-static', '-fprof-auto', '-threaded'],
-    'ghci'         : ['--interactive', '-v0', '-ignore-dot-ghci', '-fno-ghci-history', '-fghci-leak-check', '+RTS', '-I0.1', '-RTS'],
+    'ghci'         : ['--interactive', '-v0', '-ignore-dot-ghci', '-fno-ghci-history', '+RTS', '-I0.1', '-RTS'] + ['-fghci-leak-check'] if not config.compiler_debugged else [],
     'sanity'       : ['-debug'],
     'threaded1'    : ['-threaded', '-debug'],
     'threaded1_ls' : ['-threaded', '-debug'],

That almost worked. Here is the correct line:

    'ghci'         : ['--interactive', '-v0', '-ignore-dot-ghci', '-fno-ghci-history', '+RTS', '-I0.1', '-RTS'] + (['-fghci-leak-check'] if not config.compiler_debugged else []),

Note the parens around the new bit.

I will push my changes shortly, hopefully. Thanks for the quick response!

mentioned in commit 6d55e36f

NB: #15372 (closed) does not fix this bug, solving only issue (1) from the OP.

I'm OK with not fixing this. Even if we fixed it once, it would be impractical to keep it fixed in the long run.

closed

ticket:15372#comment:156913 sounds reasonable to me.

Trac metadata

Trac field	Value
Resolution	Unresolved → ResolvedWon'tFix

added Pnormal label