-O1 changes result at runtime, duplicating __DEFAULT case

Here is a program, which works as expected in GHC 8.4.1-alpha3 with -O0, but changes it behaviour with -O1.

{-# LANGUAGE MagicHash #-}

import qualified Data.Vector.Unboxed as U
import GHC.Exts

vec :: U.Vector Moebius
vec = U.singleton Moebius0

main :: IO ()
main = print $ U.head vec == U.head vec

data Moebius = Moebius0 | Moebius1 | Moebius2
  deriving (Eq)

fromMoebius :: Moebius -> Int
fromMoebius Moebius0 = 0
fromMoebius Moebius1 = 1
fromMoebius Moebius2 = 2

toMoebius :: Int -> Moebius
toMoebius (I# i#) = tagToEnum# i#

{- ...unboxed vector instances, see file attached... -}

It is expected that this program will print True. However, when compiled with -O1 it prints False.

$ ghc --version
The Glorious Glasgow Haskell Compilation System, version 8.4.0.20180204
$ ghc -O0 Sieve.hs && ./Sieve
[1 of 1] Compiling Main             ( Sieve.hs, Sieve.o ) [Optimisation flags changed]
Linking Sieve ...
True
$ ghc -O1 Sieve.hs && ./Sieve
[1 of 1] Compiling Main             ( Sieve.hs, Sieve.o ) [Optimisation flags changed]
Linking Sieve ...
False

It reproduces on OS X and Ubuntu, but worked fine in GHC 8.2.

I looked into generated Core and found a suspicious function, having two __DEFAULT cases with different bodies.

main2 :: String
main2
  = case vec `cast` <Co:3> of
    { Vector ipv_sb7L ipv1_sb7M ipv2_sb7N ->
    case <# 0# ipv1_sb7M of {
      __DEFAULT -> case main3 ipv1_sb7M of wild_00 { };
      1# ->
        case indexIntArray# ipv2_sb7N ipv_sb7L of {
          __DEFAULT -> $fShowBool4;
          __DEFAULT -> $fShowBool2;
          1# -> $fShowBool2;
          2# -> $fShowBool2
        }
    }
    }

Trac metadata

Trac field	Value
Version	8.4.1-alpha3
Type	Bug
TypeOfFailure	OtherFailure
Priority	high
Resolution	Unresolved
Component	Compiler
Test case
Differential revisions
BlockedBy
Related
Blocking
CC
Operating system
Architecture

changed milestone to %8.4.1

changed weight to 7

added Tbug Trac import labels

Attached file Sieve.hs ($1354).

changed weight to 10

Thank you for reporting this. Indeed this is an interesting case.

Trac metadata

Trac field	Value
Priority	high → highest

mentioned in commit da468130

Could not resist looking at this. I know what is happening. Patch coming.

Attached file Bug.hs ($1355).

Version without dependencies

In case it's useful, I've attached a variation of Sieve.hs without a vector dependency.

In the test case there is no need to run it. Core Lint picks up the error immediately.

mentioned in commit 4aa98f4a

I guess we should merge this.

Trac metadata

Trac field	Value
Test case	- → simplCore/should_run/T14768

added 1 deleted label

Many thanks to Bodigrim for finding this, with such a tractable test case!

closed

Merged as 4e0b4b36.

Trac metadata

Trac field	Value
Resolution	Unresolved → ResolvedFixed

removed 1 deleted label

added incorrect runtime result label

added Phighest label

mentioned in merge request !4762 (closed)